dcm4chee
  1. dcm4chee
  2. DCMEE-2097

PatientMatching does not add comma separator after sex or birthdate

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Tracking Status:
      Risk Analysis - Todo, Test Spec - ToReview, Test State - Not tested

      Description

      Noticed that after attempting to change the PatientMatching string from

      pid,issuer,ignore(" |-|\.|,|'|JR|SR"),familyname,givenname(1)|birthdate
      to
      pid,issuer,ignore(" |-|\.|,|'|JR|SR"),familyname,givenname(1)|birthdate,sex

      the resultant PatientMatching string is

      pid,issuer,ignore(" |-|\.|,|'|JR|SR"),familyname,givenname(1)|birthdatesex

        Activity

        Hide
        Christopher Archer added a comment -

        Suggested working solution:

        Index: PatientMatching.java
        ===================================================================
        — PatientMatching.java (revision 157845)
        +++ PatientMatching.java (working copy)
        @@ -327,7 +327,7 @@
        }
        }
        if (birthDateMustMatch) {

        • if (count > 0) {
          + if (count++ > 0) { sb.append(','); }
          sb.append(BIRTHDATE);
          @@ -336,7 +336,7 @@
          }
          }
          if (sexMustMatch) {
          - if (count > 0) {
          + if (count++ > 0) { sb.append(','); }

          sb.append(SEX);

        Show
        Christopher Archer added a comment - Suggested working solution: Index: PatientMatching.java =================================================================== — PatientMatching.java (revision 157845) +++ PatientMatching.java (working copy) @@ -327,7 +327,7 @@ } } if (birthDateMustMatch) { if (count > 0) { + if (count++ > 0) { sb.append(','); } sb.append(BIRTHDATE); @@ -336,7 +336,7 @@ } } if (sexMustMatch) { - if (count > 0) { + if (count++ > 0) { sb.append(','); } sb.append(SEX);

          People

          • Assignee:
            Gunter Zeilinger
            Reporter:
            Christopher Archer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development